Prevent deprecation warning in node 7.4.0 - #11
Conversation
|
I think that the callback should check and throw any potential errors instead of just silencing them. |
|
@eush77 How about printing a warning as an alternative? This wouldn’t change the current behaviour of the module (at least not drastically). |
|
I don't think printing would be wise here since it leaves no way to handle the error and can mess up with the repl prompt. And this module already throw errors related to the history file since it uses Alternatively, would you feel positive about changing |
|
@eush77 The
So I would actually follow the recommendation and use |
|
Ping (mr is ready to merge). |
|
thanks - published 0.1.4 |
Closes #10