fix scalerank 0 region boundaries, drop low-zoom names, add map_unit - #1037
Conversation
also adds map_unit boundaries and drops name at low zooms 0,1,2,3,4,5,6
|
@zerebubuth Looks like my adding |
|
The first error seems to be: Which is preventing the shapefiles for the map units being loaded. It looks like the schema doesn't contain a column called "mapcolor9", but the data does. We don't currently support loading a subset of the columns - they must all be specified in the schema. The second error seems to be: Which probably means that |
| min_zoom: *ne_region_boundaries_min_zoom | ||
| extra_columns: [scalerank] | ||
| output: {kind: region, kind_detail: '4'} | ||
| table: ne No newline at end of file |
|
LGTM |
|
I checked in some fixes. We'll see if the tests pass on circle now :fingers-crossed: |
Do they pass locally? 😜 |
I'm going to wait until the circle build finishes before answering that 😝 |
|
Our current thinking is the data files here need to be in web Mercator (but are probably in geographic now). |
…/github.com/mapzen/vector-datasource into nvkelso/992-fix-boundaries-scalerank-0-to-7
|
Last test failures are related to OSM zoom 8 content, what gives? |
|
Boundaries looked like they just needed the names swapped, possibly because the direction was reversed due to the introduction of stable ordering in #1022. The second failure looks like it was also a copy-paste issue with the tile coordinates. Works for me now, let's see if CircleCI agrees 😉 |
|
Woot! Merging. |
connects to #992 to fix scalerank 0 region boundaries
also adds map_unit boundaries and
drops name at low zooms 0,1,2,3,4,5,6