making sure query isn't null on getRows - #18
Merged
Conversation
Owner
|
I noticed this the other day. Thanks for the fix! |
Contributor
Author
|
Ah! So, if you request a cell that does not have content, google will actually not return any cells to you, which would cause getCells to return nothing as well. If you're retrieving cells to be able to write into them, then you want to get those empty cells back. Setting returnEmpty to true will let you do that. |
Contributor
Author
|
Also, sorry for clobbering both into the same PR, I didn't mean to, but I am building an app a bit under the gun and so having to rely on my fork until these things are in =). |
theoephraim
added a commit
that referenced
this pull request
Mar 28, 2015
making sure query isn't null on getRows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issue #15.