new import syntax for modules#70
Merged
Merged
Conversation
cowboyd
force-pushed
the
new-module-syntax
branch
from
9debce8 to
dc12dc1
Compare
Import syntax and module semantics are suboptimal. See #57 for a write-up. To summarize, this makes imports a map instead of a list: **before** ```yaml $import: - names: [capitalize,decapitalize] from: https://pls.pub/std@1.0.0/strings.yaml - names: [parse] from https://pls.pub/x/parse.yaml ``` **after** ```yaml $import: capitalize, decapitalize: https://pls.pub/std@1.0.0/strings.yaml parse: https://pls.pub/x/parse.yaml ``` This also simplifies the module semantics. Modules do not have a list of symbols and a value, they just have a value, and that value you can imported key by key: ```yaml $import: something: https://pls.pub/x/things@1.0.0/mod.yaml ``` Or, use the `<<` merge key after a symbol name to indicate that the _entire module value_ should be bound to that name. ```yaml $import: everything<<: https://pls.pub/x/things@1.0.0/mod.yaml ``` There is not currently a method to alias imported names, but that should be provide for eventually.
cowboyd
force-pushed
the
new-module-syntax
branch
from
dc12dc1 to
6c363c2
Compare
taras
approved these changes
Feb 3, 2023
Member
taras
left a comment
taras
left a comment
There was a problem hiding this comment.
We should document this immediately
This was referenced Feb 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Import syntax and module semantics are suboptimal. See #57 for a write-up.
Approach
To summarize, this makes imports a map instead of a list:
before
after
This also simplifies the module semantics. Modules do not have a list of symbols and a value, they just have a value, and that value you can imported key by key.
Or, use the
<<merge key after a symbol name to indicate that the entire module value should be bound to that name.It is possible to have both a slurp everything import and a named import:
There is not currently a method to alias imported names, but that should be provide for eventually.