Remove unused @ClassRule container in KafkaContainerTest and use cp-kafka:6.2.1 as default - #4564
Conversation
* Also, upgrade to cp-kafka:6.2.1 as default image in tests to use a container-aware JVM. * Instead of explicitly checking for platform 6 compatibility, the test now checks for platform 5 compatibility instead. * Remove a test for the deprecated constructor.
| @@ -50,7 +45,7 @@ public void testUsage() throws Exception { | |||
| public void testUsageWithSpecificImage() throws Exception { | |||
There was a problem hiding this comment.
I think no real need to keep the general testUsage() as well as the testUsageWithSpecificImage test. Since testUsageWithSpecificImage is used for inlining code in the docs, I would keep this one.
👍
Seems sensible to me
I think it would be a good idea to keep this, TBH... |
|
Sure, I brought the test for the legacy constructor back. |
3 participants
Since we still saw some flakiness from
KafkaContainerTestin our CI, I tried to remove some of the elements that I thought of as unnecessary.The
@ClassRuleannotated container was never used in any tests and was just left there for the sake of including its code in the documentation. IMO it is not useful to add test framework integration to each container module documentation, since it is not specific for the container.The update to
cp-kafka:6.2.1was done to use a container-aware JVM so we have better guarantees for the memory configuration. Accordingly, I changed the testtestConfluentPlatformVersion6test to check instead compatibility with platform version 5, although we could consider removing this as well?I also removed the test for the deprecated tag version constructor, but if you still want to guard against potential regressions, we can of course keep it.