Skip to content

Switch from AdoptOpenJDK to Temurin and latest JDK 8. - #4537

Merged
pioorg merged 2 commits into
masterfrom
changed-jdk-version
Oct 4, 2021
Merged

Switch from AdoptOpenJDK to Temurin and latest JDK 8.#4537
pioorg merged 2 commits into
masterfrom
changed-jdk-version

Conversation

@pioorg

@pioorg pioorg commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

This change is for migrating from AdoptOpenJDK to Eclipse Temurin.
Perhaps going for the latest Java 8 version again is worth considering?

@kiview

kiview commented Oct 4, 2021

Copy link
Copy Markdown
Member

@rnorth switched to the pinned version in this commit:
669cc53

But I can't remember any discussion in favor of pinning to an actual version and AFAIR we just wanted to switch to a working version back then. IMO using the latest Java 8 is reasonable.

@rnorth

rnorth commented Oct 4, 2021

Copy link
Copy Markdown
Member

I don't recall the specific trigger to pin the version exactly, but it's likely a general habit of wanting to pin for reproduceability. In the light of issues like mirromutth/r2dbc-mysql#182, I think this pinning is actually valuable. Could we perhaps reinstate the precise latest version of Temurin 1.8?

@pioorg

pioorg commented Oct 4, 2021

Copy link
Copy Markdown
Contributor Author

Version is pinned now.

@kiview kiview left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pioorg
pioorg merged commit dd93725 into master Oct 4, 2021
@delete-merged-branch
delete-merged-branch Bot deleted the changed-jdk-version branch October 4, 2021 09:51
@kiview kiview added this to the next milestone Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants