Skip to content

Switch from using Travis to GitHub Actions for release - #3434

Merged
rnorth merged 4 commits into
masterfrom
gha-release
Jul 8, 2021
Merged

Switch from using Travis to GitHub Actions for release#3434
rnorth merged 4 commits into
masterfrom
gha-release

Conversation

@rnorth

@rnorth rnorth commented Nov 5, 2020

Copy link
Copy Markdown
Member

@rnorth
rnorth requested review from bsideup and kiview as code owners November 5, 2020 20:56
@rnorth
rnorth marked this pull request as draft November 5, 2020 20:59
Comment thread .github/workflows/release.yml Outdated
Comment thread README.md

> Testcontainers is a Java library that supports JUnit tests, providing lightweight, throwaway instances of common databases, Selenium web browsers, or anything else that can run in a Docker container.

[![Build Status](https://travis-ci.org/testcontainers/testcontainers-java.svg?branch=master)](https://travis-ci.org/testcontainers/testcontainers-java)[ ![Download](https://api.bintray.com/packages/testcontainers/releases/testcontainers/images/download.svg) ](https://bintray.com/testcontainers/releases/testcontainers/_latestVersion)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removing without replacing, as I doubt anybody will miss it.

Comment thread build.gradle Outdated
@@ -60,8 +57,6 @@ subprojects {
}
}
}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this publishing block should probably be consolidated into publishing.gradle. Will do that, checking that there's not some weird side-effect in the set of generated artifacts.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Have confirmed that the resulting set of artifact filenames is the same, and we're still getting the shaded JAR for testcontainers core.
@rnorth
rnorth marked this pull request as ready for review June 29, 2021 11:21
@rnorth rnorth mentioned this pull request Jun 29, 2021
@rnorth
rnorth requested a review from bsideup July 1, 2021 13:12
@rnorth
rnorth merged commit 5d87f61 into master Jul 8, 2021
@rnorth
rnorth deleted the gha-release branch July 8, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants