Skip to content

chore: Improve null check, test typing, and IDE settings - #1757

Merged
HofmeisterAn merged 3 commits into
developfrom
feature/use-theory-data-in-endpoint-authentication-tests
Sep 4, 2026
Merged

chore: Improve null check, test typing, and IDE settings#1757
HofmeisterAn merged 3 commits into
developfrom
feature/use-theory-data-in-endpoint-authentication-tests

Conversation

@HofmeisterAn

@HofmeisterAn HofmeisterAn commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Converts the auth-provider theory data to typed TheoryData<T1, T2> to resolve xUnit analyzer findings, and removes null-forgiving (!) operators across src/ and tests/ since nullable
reference types aren't enabled and they were no-ops kept only to silence ReSharper. The two related inspections are now SUGGESTION.

Why is it important?

-

Related issues

-

Summary by CodeRabbit

  • Code Quality

    • Improved nullability annotations and removed unnecessary null-suppression usage without changing runtime behavior.
  • Tests

    • Strengthened test data typing and streamlined test code while maintaining existing coverage and behavior.
  • Developer Experience

    • Updated spell-checking terms and IDE inspection settings for more consistent development workflows.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Sep 3, 2026
@netlify

netlify Bot commented Sep 3, 2026

Copy link
Copy Markdown

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit df94d90
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/6a99b6e49f76fe00081c462a
😎 Deploy Preview https://deploy-preview-1757--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: c9c480d3-aea4-4eab-bcfd-f8b9a438d086

📥 Commits

Reviewing files that changed from the base of the PR and between 6581499 and df94d90.

📒 Files selected for processing (11)
  • Testcontainers.dic
  • Testcontainers.sln.DotSettings
  • src/Testcontainers/Clients/TestcontainersClient.cs
  • src/Testcontainers/Containers/DockerContainer.cs
  • tests/Testcontainers.AspireDashboard.Tests/AspireDashboardContainerTest.cs
  • tests/Testcontainers.Databases.Tests/DatabasesContainerTest.cs
  • tests/Testcontainers.LowkeyVault.Tests/LowkeyVaultContainerTest.cs
  • tests/Testcontainers.Platform.Linux.Tests/TarOutputMemoryStreamTest.cs
  • tests/Testcontainers.Playwright.Tests/PlaywrightContainerTest.cs
  • tests/Testcontainers.Tests/Unit/Builders/CommonDirectoryPathTest.cs
  • tests/Testcontainers.Tests/Unit/Configurations/DockerEndpointAuthenticationProviderTest.cs
🚧 Files skipped from review as they are similar to previous changes (11)
  • src/Testcontainers/Containers/DockerContainer.cs
  • Testcontainers.dic
  • tests/Testcontainers.LowkeyVault.Tests/LowkeyVaultContainerTest.cs
  • tests/Testcontainers.Tests/Unit/Builders/CommonDirectoryPathTest.cs
  • Testcontainers.sln.DotSettings
  • tests/Testcontainers.AspireDashboard.Tests/AspireDashboardContainerTest.cs
  • tests/Testcontainers.Tests/Unit/Configurations/DockerEndpointAuthenticationProviderTest.cs
  • src/Testcontainers/Clients/TestcontainersClient.cs
  • tests/Testcontainers.Databases.Tests/DatabasesContainerTest.cs
  • tests/Testcontainers.Playwright.Tests/PlaywrightContainerTest.cs
  • tests/Testcontainers.Platform.Linux.Tests/TarOutputMemoryStreamTest.cs

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


Walkthrough

The change updates spell-check and inspection settings, removes redundant null-forgiving operators from production and test code, and converts authentication test data to strongly typed TheoryData collections.

Changes

Nullability and test quality

Layer / File(s) Summary
Dictionary and inspection settings
Testcontainers.dic, Testcontainers.sln.DotSettings
Adds dictionary entries and updates nullable inspection severity settings.
Production nullability annotations
src/Testcontainers/Clients/TestcontainersClient.cs, src/Testcontainers/Containers/DockerContainer.cs
Removes redundant null-forgiving operators without changing runtime behavior.
Test nullability cleanup
tests/Testcontainers.*.Tests/*, tests/Testcontainers.Tests/Unit/Builders/CommonDirectoryPathTest.cs
Removes redundant null-forgiving operators from test code.
Strongly typed authentication test data
tests/Testcontainers.Tests/Unit/Configurations/DockerEndpointAuthenticationProviderTest.cs
Replaces List<object[]> collections with typed TheoryData collections and direct typed arguments.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to df94d

This change strengthens authentication test-data typing and removes redundant null-forgiving operators without an identified current-head production risk.

Poem

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 9 files. (2 skipped: … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main changes: null-forgiving operator cleanup, typed test data, and IDE settings updates.
Description check ✅ Passed The description explains the main changes and their purpose. The mandatory rationale section contains only a placeholder, and no testing steps are provided, but the description is otherwise relevant a…
Full details: Docstring Coverage

Explanation

Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 9 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/use-theory-data-in-endpoint-authentication-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@HofmeisterAn
HofmeisterAn marked this pull request as ready for review September 3, 2026 18:05
@HofmeisterAn HofmeisterAn changed the title Feature/use theory data in endpoint authentication tests chore: Improve null check, test typing, and IDE settings Sep 4, 2026
@HofmeisterAn
HofmeisterAn merged commit 1852091 into develop Sep 4, 2026
212 of 236 checks passed
@HofmeisterAn
HofmeisterAn deleted the feature/use-theory-data-in-endpoint-authentication-tests branch September 4, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant