💥 Reject conflicting namespace update flags - #1187
Open
qyc5937 wants to merge 3 commits into
Open
Conversation
|
|
qyc5937
marked this pull request as draft
September 1, 2026 23:17
qyc5937
marked this pull request as ready for review
September 1, 2026 23:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
None.
What changed?
operator namespace update --active-clusterwhen it is combined with another namespace mutation flag.--promote-global/--active-clustererror and remove the misleading "other flag will be omitted" message from active-cluster updates.💥 Breaking change
Commands that combine
--active-clusterwith another namespace mutation flag previously exited successfully after silently discarding the other requested updates. They now fail before issuing an RPC in both text and JSON output modes.Apply namespace configuration first, then change the active cluster in a separate command. Active-cluster-only updates are unchanged.
Checklist
Stability
-o json/-o jsonl) are treated as breaking changesDesign
Help text
YourXxxformBehavior
Tests
SharedServerSuite)func TestXxx) where applicableManual tests
Setup
Used two OSS clusters at
127.0.0.1:7233and127.0.0.1:8233with a global namespace initially active incluster-aand replicated only tocluster-a.Happy path
Error case
The same command with
--output jsonreturns the same error and exit status. Namespace state remains unchanged.Composition
Both clusters subsequently reported
cluster-bas active.Automated tests
go test -tags test_dep ./internal/temporalcli -run "TestNamespaceUpdate_ActiveCluster|TestSharedServerSuite/TestNamespaceUpdate_ActiveClusterAlone" -count=1go test -tags test_dep ./...(namespace tests passed; unrelatedTestDeployment_Listpropagation assertion flaked once and passed on isolated retry)go vet -tags test_dep ./...(reports existing warnings in task queue and command context code)make gengit diff --check