still fix rsync to use .gitignore

[cgwalters]

I tried to do this in #3037 but I think a new rsync invocation may have snuck in.

Basically tmt is unusable in a Rust project by default.

[happz]

Can you provide a reproducer we could use to investigate?

[LecrisUT]

Packit has fmf_path to point to different fmf root, but you need to be conscious that you would only have access to the files under that path.

But yeah, we could use some more context on what you are trying to do and what is missing. Fwiw, in Fedora packaging you are generally using a crate archive and you could make packit do a similar packaging as well instead of using the git archive.

[cgwalters]

Packit has fmf_path to point to different fmf root, but you need to be conscious that you would only have access to the files under that path.

Thanks! That is totally fine and actually what I always want really. Will look at that next.

Can you provide a reproducer we could use to investigate?

I tried to make a quick reproducer but failed =/ I'm deep in another rework of how we do tmt and ended up currently working around this by mkdir target/tmt-tmp && rsync -a .fmf tests target/tmt-tmp/ which works fine for now.

[thrix]

@cgwalters can you back to us so we are able to understand clearly what is the issue please?

[cgwalters]

The issue is that there's some code in tmt which rsyncs the entire current directory into the target system and this is just horrendously bad with at least Rust projects which can have multiple gigabytes of incremental caches in target/.

Docker has .dockerignore, git has .gitignore, but tmt honors neither of those.

(Tangent: I am tempted to try to force always running tmt from a container image which would mean .dockerignore is automatically honored, but this has some other tradeoffs)

[cgwalters]

FWIW right now in bootc we have a tmt wrapper for this reason (also that we replace testcloud provisioner with https://github.com/bootc-dev/bcvk because of #4203 among other things)

https://github.com/bootc-dev/bootc/blob/369859d61c7ab9aeb33b5c2c389298abb2dcd225/crates/xtask/src/tmt.rs#L249