Skip to content

fix/link not null create T1361 #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nichenqin merged 1 commit into from
Dec 23, 2025
Merged

fix/link not null create T1361 #2332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions apps/nestjs-backend/src/features/record/record.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import type {
IFilterSet,
IGridColumnMeta,
IGroup,
ILinkFieldOptions,
ILinkCellValue,
IRecord,
ISnapshotBase,
Expand Down Expand Up @@ -1295,6 +1296,32 @@ export class RecordService {
}, {});
}

private hasPersistedLinkColumn(field: FieldCore) {
if (field.type !== FieldType.Link) {
return true;
}

const options = field.options as ILinkFieldOptions | undefined;
if (!options) {
return true;
}

const inferredForeignKeyName =
options.foreignKeyName ??
(options.relationship === Relationship.ManyOne || options.relationship === Relationship.OneOne
? field.dbFieldName
: undefined);
const inferredSelfKeyName =
options.selfKeyName ??
(options.relationship === Relationship.OneMany && options.isOneWay === false
? field.dbFieldName
: undefined);

return (
field.dbFieldName !== inferredForeignKeyName && field.dbFieldName !== inferredSelfKeyName
);
}

private async createBatch(
table: TableDomain,
records: IRecordInnerRo[],
Expand All @@ -1316,8 +1343,8 @@ export class RecordService {

const validationFields = fields
.filter((f) => !f.isComputed)
.filter((f) => f.type !== FieldType.Link)
.filter((field) => field.notNull || field.unique);
.filter((field) => field.notNull || field.unique)
.filter((field) => this.hasPersistedLinkColumn(field));

const user = this.cls.get('user');
const auditUserValue =
Expand Down
Loading