Skip to content

Update tests for ECMA262 #2216 - #2878

Merged
rwaldron merged 1 commit into
tc39:mainfrom
devsnek:default-constructor-refactor
Feb 26, 2021
Merged

Update tests for ECMA262 #2216#2878
rwaldron merged 1 commit into
tc39:mainfrom
devsnek:default-constructor-refactor

Conversation

@devsnek

@devsnek devsnek commented Oct 27, 2020

Copy link
Copy Markdown
Member

@rwaldron

Copy link
Copy Markdown
Contributor

I'll take a look at this and the related PR tomorrow—thanks!

@devsnek
devsnek dismissed a stale review via f160c2c October 27, 2020 23:24
@devsnek
devsnek force-pushed the default-constructor-refactor branch from 73dd91b to f160c2c Compare October 27, 2020 23:24
@rwaldron rwaldron added awaiting specification awaiting consensus This needs committee consensus before it can be eligible to be merged. and removed awaiting specification labels Oct 28, 2020
Comment thread test/built-ins/Function/internals/Call/class-ctor-realm.js
@rwaldron

Copy link
Copy Markdown
Contributor

@devsnek now that this has consensus, is it ready to merge?

@rwaldron rwaldron added the has consensus This has committee consensus label Nov 18, 2020
@devsnek

devsnek commented Nov 18, 2020

Copy link
Copy Markdown
Member Author

It should be.

@rwaldron rwaldron removed the awaiting consensus This needs committee consensus before it can be eligible to be merged. label Nov 18, 2020
Comment thread test/built-ins/Function/internals/Call/class-ctor-realm.js Outdated
@ljharb

ljharb commented Feb 24, 2021

Copy link
Copy Markdown
Member

@rwaldron can this land? test262 tests are intended to land before the spec PR.

@rwaldron

Copy link
Copy Markdown
Contributor

@ljharb There's an unaddressed question from @ExE-Boss

@devsnek
devsnek force-pushed the default-constructor-refactor branch from f160c2c to 6e2c41c Compare February 25, 2021 16:46
@ljharb
ljharb requested a review from rwaldron February 26, 2021 05:57
@rwaldron

Copy link
Copy Markdown
Contributor

Thanks everyone!

@rwaldron
rwaldron merged commit 516ca9a into tc39:main Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has consensus This has committee consensus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants