fix: handle YAML mapping indicators in driver names - #625
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughSession-data YAML preprocessing now quotes scalar values beginning with ChangesYAML Mapping Indicator Parsing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/app/irsdk/node/irsdk-node.ts`:
- Around line 222-227: Update fixMappingIndicatorValues so the mapping-indicator
regex suffix cannot consume newline characters or span into the next YAML line;
allow only horizontal whitespace and other non-newline characters after ?. Add a
regression test covering a bare UserName: ? followed by another key, verifying
the next key remains intact after parsing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cb47df25-bf00-4a23-a20c-58284dbf6ef1
📒 Files selected for processing (2)
src/app/irsdk/node/irsdk-node.spec.tssrc/app/irsdk/node/irsdk-node.ts
Description
Screenshots
Before
After
Type of Change
Checklist
npm testnpm run lintand fixed any issuesSummary by CodeRabbit
?).UserNamevalues and ensuring subsequent keys still parse correctly.