Skip to content

fix(node): retry config error startup failures - #3327

Merged
brianp merged 1 commit into
tari-project:mainfrom
samrusani:fix/handle-wallet-config-error-101
Jul 7, 2026
Merged

fix(node): retry config error startup failures#3327
brianp merged 1 commit into
tari-project:mainfrom
samrusani:fix/handle-wallet-config-error-101

Conversation

@samrusani

Copy link
Copy Markdown
Contributor

Fixes #2831

Summary

  • treat node exit code 101 as a recoverable startup error
  • reuse the existing node cleanup and retry path for config-error startup failures
  • update the focused stop-on-error-code test

Validation

  • cargo fmt
  • git diff --check
  • cargo +1.93.0 check
  • cargo +1.93.0 test node_manager_test::stop_on_error_codes_contains_expected_values

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the error code 101 to the STOP_ON_ERROR_CODES array in node_manager.rs, updates the corresponding unit tests to verify this change, and updates a warning log message in phase_node.rs to refer to 'Node data or config' instead of 'Database for node'. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@brianp
brianp merged commit f1275a0 into tari-project:main Jul 7, 2026
13 checks passed
@brianp

brianp commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle error 101

2 participants