Remove similar trailer keys from commit hook - #226
Merged
Merged
Conversation
The duplicated "Close" and "Closes" keys will possibly cause
inconsistency between commit messages. The one being kept is "Closes"
because the implied subject is "this patch", so it should complete the
following sentence:
This patch [closes]...
just like sentences in the body of a message.
"Bug" is also removed due to its similarity to "Closes a bug".
Change-Id: Idea7c0310249c603e550a7a4e27df490efe13d4c
Contributor
|
Thank @lumynou5 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The duplicated "Close" and "Closes" keys will possibly cause inconsistency between commit messages. The one being kept is "Closes" because the implied subject is "this patch", so it should complete the following sentence:
just like sentences in the body of a message.
"Bug" is also removed due to its similarity to "Closes a bug".
Change-Id: Idea7c0310249c603e550a7a4e27df490efe13d4c