Skip to content

chore: memoize clsx() (alternative) - #15456

Merged
Rich-Harris merged 6 commits into
sveltejs:mainfrom
adiguba:memoize-clsx
Mar 6, 2025
Merged

chore: memoize clsx() (alternative)#15456
Rich-Harris merged 6 commits into
sveltejs:mainfrom
adiguba:memoize-clsx

Conversation

@adiguba

@adiguba adiguba commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Rewrite of the PR #15441

Call to clsx() are memoized in template_effect().
Same things for class directives, allowing to skip comparaison when they are not modified (as object is the same)

Exemple :

<div class={className} class:blue={blue}> </div>

Actual generated code :

	let classes;
	$.template_effect(() => {
		classes = $.set_class(div, 1, $.clsx($$props.className), null, classes, { blue: $$props.blue });
	});

With this PR :

	let classes;
	$.template_effect(
		($0, $1) => {
			classes = $.set_class(div, 1, $0, null, classes, $1);
		},
		[
			() => $.clsx($$props.className),
			() => ({ blue: $$props.blue })
		]
	);

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot

changeset-bot Bot commented Mar 5, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 153875c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adiguba adiguba mentioned this pull request Mar 5, 2025
6 tasks
@github-actions

github-actions Bot commented Mar 5, 2025

Copy link
Copy Markdown
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15456

@Rich-Harris Rich-Harris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Rich-Harris
Rich-Harris merged commit ae615ae into sveltejs:main Mar 6, 2025
@github-actions github-actions Bot mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants