Skip to content

Fix fatal error when parsing URLs in Node adapter - #802

Merged
Rich-Harris merged 4 commits into
masterfrom
gh-801
Mar 31, 2021
Merged

Fix fatal error when parsing URLs in Node adapter#802
Rich-Harris merged 4 commits into
masterfrom
gh-801

Conversation

@Conduitry

Copy link
Copy Markdown
Member

Fixes the bug with the Node adapter in #801, and also performs the tidying I mentioned in that issue for the Vercel adapter.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris
Rich-Harris merged commit feb2db7 into master Mar 31, 2021
@Rich-Harris
Rich-Harris deleted the gh-801 branch March 31, 2021 19:28
@benmccann

Copy link
Copy Markdown
Member

Thanks for the quick fix and sorry for breaking! I forgot the tests don't cover adapter-node

@samccone

Copy link
Copy Markdown
Contributor

I have sent a PR to add test coverage for adapter-node which would have caught this case
#807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants