Skip to content

rename app.render to server.respond - #4034

Merged
Rich-Harris merged 5 commits into
masterfrom
gh-4030
Feb 21, 2022
Merged

rename app.render to server.respond#4034
Rich-Harris merged 5 commits into
masterfrom
gh-4030

Conversation

@Rich-Harris

@Rich-Harris Rich-Harris commented Feb 21, 2022

Copy link
Copy Markdown
Member

Closes #4030class App becomes class Server

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot

changeset-bot Bot commented Feb 21, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b4120b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-vercel Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread .changeset/late-bobcats-brake.md Outdated
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@Rich-Harris
Rich-Harris merged commit f223f91 into master Feb 21, 2022
@Rich-Harris
Rich-Harris deleted the gh-4030 branch February 21, 2022 21:59
@benmccann

Copy link
Copy Markdown
Member

CC'ing the community adapter authors: @jthegedus @pluvial @geoffrich @MacFJA @HalfdanJ @ryanbethel

As part of putting up our new types documention we renamed the App.render to Server.respond to avoid conflicting with the App namespace`, so a small update will be needed to any adapter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename App

2 participants