Skip to content

make static assets immutable - #3222

Merged
Rich-Harris merged 7 commits into
masterfrom
immutable-assets
Jan 7, 2022
Merged

make static assets immutable#3222
Rich-Harris merged 7 commits into
masterfrom
immutable-assets

Conversation

@Rich-Harris

@Rich-Harris Rich-Harris commented Jan 6, 2022

Copy link
Copy Markdown
Member

first part of #3194

  • adapter-cloudflare
  • adapter-cloudflare-workers
  • adapter-netlify
  • adapter-node
  • adapter-vercel

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot

changeset-bot Bot commented Jan 6, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3165f99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sveltejs/kit Patch
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Jan 6, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 3165f99

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d85f170d6b4d000862df83

@Rich-Harris

Copy link
Copy Markdown
Member Author

cases this doesn't (yet) address:

  • paths.assets is set, meaning assets are hosted externally. in these cases, manifest.assets should be empty, and adapters probably shouldn't attempt to deploy or serve static files or write custom headers for them
  • paths.base is set. adapters are probably doing several wrong things here

i think it's probably better to figure those out separately

@Rich-Harris
Rich-Harris marked this pull request as ready for review January 6, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant