Skip to content

[feat] return list of copied files from copy utils - #2674

Merged
benmccann merged 7 commits into
masterfrom
copy-utils
Oct 25, 2021
Merged

[feat] return list of copied files from copy utils#2674
benmccann merged 7 commits into
masterfrom
copy-utils

Conversation

@pngwn

@pngwn pngwn commented Oct 24, 2021

Copy link
Copy Markdown
Member

Returns what files have been copied from the copy utilities provided to adapters. This way adapters can easily determine what files have been copied.

@changeset-bot

changeset-bot Bot commented Oct 24, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b198e93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm

Copy link
Copy Markdown
Member

General thought: are there other things devs might want to have returned from this in the future? If yes, future-proof the API by returning an object with just the files property for now?

@pngwn

pngwn commented Oct 24, 2021

Copy link
Copy Markdown
Member Author

This returns the source of the copied files. the only additional thing I can think of returning is the target they are copied to. That can easily be deduced by the consumer, as this is a straightforward recursive copy, but that is the only other thing that comes to mind.

If we wanted to do this then we could return and object of { source: Array<string> } which could later be expanded to { source: Array<string>, target: Array<string> }

Comment thread packages/kit/src/core/adapt/utils.js
@benmccann benmccann changed the title Copy utils [feat] copy utils Oct 24, 2021
Comment thread packages/kit/types/config.d.ts Outdated
@benmccann benmccann changed the title [feat] copy utils [feat] return list of copied files from copy utils Oct 25, 2021
@benmccann
benmccann merged commit fa25813 into master Oct 25, 2021
@benmccann
benmccann deleted the copy-utils branch October 25, 2021 17:56
This was referenced Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants