Add sync functions - #9
Conversation
Add pytests Throw errors instead of returning them
anand2312
left a comment
anand2312
left a comment
There was a problem hiding this comment.
Haven't tested yet but a few comments
There was a problem hiding this comment.
I don't really like the create_client functions tbh; what do you think about just not providing them? It's easy enough for the user to just import the client they want and instantiate it, the create_client functions don't really do much else either so it feels like bloat
There was a problem hiding this comment.
I think this should be removed too but this will be a breaking change and we should remove this in all the python libraries at the same time.
There was a problem hiding this comment.
I agree - we can add deprecation warnings to all of them now and remove them soon
Co-authored-by: Anand <40204976+anand2312@users.noreply.github.com>
Co-authored-by: Anand <40204976+anand2312@users.noreply.github.com>
Co-authored-by: Anand <40204976+anand2312@users.noreply.github.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
anand2312
left a comment
anand2312
left a comment
There was a problem hiding this comment.
LGTM. Nice work on the tests too!
3 participants
What kind of change does this PR introduce?
Update with sync functions, added pytests and throw error messages instead of returning them.
What is the current behavior?
There are only async functions, no pytests and errors are returned
What is the new behavior?
We now have sync functions, pytests and errors are thrown
Additional context
Addresses #6