Edit setup#168
Conversation
| Additionally, it is important to clone the relevant submodules required by SU2; a list of which is stored in [`.gitmodules`](https://github.com/su2code/SU2/blob/master/.gitmodules). To clone these submodules executing | ||
| ``` | ||
| git submodule update --init --remote | ||
| ``` | ||
| will download the subdmodules locally. |
There was a problem hiding this comment.
Ah yes, that is correct. Would then it be a nice addition to add a section for meson setup in Build-from-Source.md? I only wanted to setup SU2 (i.e., bring it to a an error-free status) and not build it. However I found no section in which this is stated and stumbled across meson setup accidentally.
There was a problem hiding this comment.
Sure, and you can mention here that --init is done as part of meson.py, instead of suggesting it should be done manually.
There was a problem hiding this comment.
I have updated the changes. Let me know if any more changes are needed.
There was a problem hiding this comment.
Hello @pcarruscag . Could you please update the status of this PR? Or please let know if this change may require further improvements. Thanks! :D
There was a problem hiding this comment.
I'll take a look soon, sorry for the delay.
* Respect the keyword 'local' while configuring git user names and emails. * Syntax highlight the words 'user.name' and 'user.email' for clarity.
* Reference the correct files for upcoming changes. Signed-off-by: Shourya Shukla <periperidip@gmail.com>
Signed-off-by: Shourya Shukla <periperidip@gmail.com>
periperidip
force-pushed
the
edit_setup
branch
from
e8eec7a to
dcf0a77
Compare
2 participants
No description provided.