Upgrade to Electron 43 - #1765
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades the repository’s Electron runtime to v43 to align obs-studio-node’s build/test environment with Streamlabs Desktop’s Electron 43 baseline.
Changes:
- Bump
electrondevDependency to43.2.0. - Update native build configuration to use Electron 43 headers/runtime version.
- Update CI to use Node.js
24.xand Electron43.2.0.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates the Electron devDependency to 43.2.0. |
| obs-studio-client/CMakeLists.txt | Updates the cached Electron/headers version used by the native client build. |
| ci/configure-osn-osx.sh | Changes how the macOS deployment target is passed to CMake (now via env var). |
| .github/workflows/main.yml | Updates CI environment Electron version and moves CI Node.js to 24.x across jobs. |
| .github/workflows/check-js-generated.yml | Updates CI Node.js version to 24.x. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
summeroff
approved these changes
Aug 25, 2026
fix CI build error: D:\a\obs-studio-node\obs-studio-node\streamlabs-build.app\obs-studio-client\iojs\v43.2.0\include\v8config.h(13,1): error C1189: #error: "C++20 or later required." [D:\a\obs-studio-node\obs-studio-node\streamlabs-build.app\obs-studio-client\obs_studio_client.vcxproj] (compiling source file '../../obs-studio-client/source/callback-manager.cpp')
aleksandr-voitenko
approved these changes
Aug 25, 2026
Resolve issue: ERROR: TypeScript import equals declaration is not supported in strip-only mode (node:26607) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///Users/rosbo/projects/streamlabs/obs-studio-node/tests/osn-tests/src/test_audio_encoder.ts is not specified and it doesn't parse as CommonJS. Reparsing as ES module because module syntax was detected. This incurs a performance overhead. To eliminate this warning, add "type": "module" to /Users/rosbo/projects/streamlabs/obs-studio-node/package.json. (Use `Electron --trace-warnings ...` to show where the warning was created)
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 25 changed files in this pull request and generated no new comments.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
tests/osn-tests/src/test_osn_service.ts:12
chai-subsetis a CommonJSexport =plugin; importing it viaimport * as chaiSubset from 'chai-subset'compiles to a namespace object (via__importStar) rather than the callable plugin function. This will typically breakchai.use(chaiSubset)at runtime and can also fail type-checking with the currenttsconfig.json(noesModuleInterop).
import * as chai from 'chai';
import * as chaiSubset from 'chai-subset'
chai.use(chaiSubset);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to Electron 43 to be consistent with Streamlabs Desktop Electron 43 upgrade. Upgrade project to C++ 20 to resolve compile errors with Electron 43.
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: