ci: add aggregate CI Gate as the single required status check#37
Merged
zastrowm merged 1 commit intoJun 18, 2026
Merged
Conversation
The CI matrix produces ~30 dynamically-named check runs (e.g. "Python (ubuntu-latest, 3.14)", "Node.js (macos-latest, Node 22)"). Requiring each one in branch protection is brittle: every time the matrix changes, the required-checks list silently drifts and a leg can be dropped without anyone noticing. Add a single "CI Gate" job that `needs` all four real jobs (rust, python, audit, node) and fails unless every one of them succeeded (catching failures *and* cancellations via `needs.*.result`). Branch protection only has to require this one stable context, so the gate stays correct as the matrix evolves. Refs strands-agents#32
2 tasks
zastrowm
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Works toward #32 ("Run tests on PRs and require to pass before merging").
The first box of #32 — workflows that run on PRs — is already done:
ci.ymlruns the Rust, Python, Node, and security-audit jobs on every PR, andpr-title.ymlvalidates the title. The remaining gap is the second box: the checks aren't required before merge.This PR makes requiring them robust.
The problem with requiring the matrix legs directly
The CI matrix expands to ~30 dynamically-named check runs, e.g.:
Marking each of these as a required status check in branch protection is brittle — every time the Python/Node version matrix changes, the required-checks list silently drifts, and a whole leg can be dropped from the gate without anyone noticing.
The fix
Add a single
CI Gatejob thatneeds: [rust, python, audit, node]and fails unless every needed job succeeded. It usesif: always()+join(needs.*.result, ' ')so it also catches cancelled jobs, not just failures.Branch protection then only needs to require the one stable context
CI Gate, which stays correct as the matrix evolves.Admin follow-up required (cannot be done in a PR)
Requiring the check is a repo setting, not a file. A maintainer needs to enable it. The repo already has a disabled ruleset named
main-only rulestargetingmainthat enforces reviews but has no status-check rule. Recommended: enable that ruleset and add arequired_status_checksrule for contextCI Gate(integration: GitHub Actions). I've left the exact API/UI steps on #32.Testing
python -c "import yaml; yaml.safe_load(...)"parses cleanly; 5 jobs present with correctneeds.actionlint .github/workflows/ci.yml→ clean.Notes for the reviewer
.github/workflows/ci.yml); no behavior change to the existing jobs.auditis intentionally included in the gate (it builds + runsnpm audit --omit=dev; the RustSeccargo auditstep iscontinue-on-errorso the job still passes while advisories are triaged).PR title follows Conventional Commits (
ci:).