Skip to content

Core: Zoom tool refinements - Hide reset button when value is initial #33635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sidnioulz merged 8 commits into from
Mar 3, 2026
Merged

Core: Zoom tool refinements - Hide reset button when value is initial #33635

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a0ee09e
feat: hide the reset zoom button when at the initial zoom level inste…
superLipbalm Jan 24, 2026
b04ffe2
refactor: adjust whitespace in zoom reset button style property
superLipbalm Jan 25, 2026
bbd480e
refactor: Conditionally render the zoom reset button instead of toggl…
superLipbalm Jan 26, 2026
547521b
feat: Introduce a `hidden` prop to the `Button` component and utilize…
superLipbalm Feb 26, 2026
e2d16ff
Revert "feat: Introduce a `hidden` prop to the `Button` component and…
superLipbalm Feb 28, 2026
2952d6b
Refactor: Replace conditional rendering of the zoom reset button with…
superLipbalm Feb 28, 2026
93f30d9
feat: use `hidden` attribute instead of `aria-hidden` for the zoom re…
superLipbalm Mar 1, 2026
2dc2b04
Revert "feat: use `hidden` attribute instead of `aria-hidden` for the…
superLipbalm Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions code/core/src/manager/components/preview/tools/zoom.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,16 @@ export const Zoom = memo<{
</ActionList.Button>
}
after={
<ActionList.Button
size="small"
padding="small"
disabled={value === INITIAL_ZOOM_LEVEL}
onClick={() => zoomTo(INITIAL_ZOOM_LEVEL)}
ariaLabel="Reset zoom"
>
<UndoIcon />
</ActionList.Button>
value !== INITIAL_ZOOM_LEVEL && (
<ActionList.Button
size="small"
padding="small"
onClick={() => zoomTo(INITIAL_ZOOM_LEVEL)}
ariaLabel="Reset zoom"
>
<UndoIcon />
</ActionList.Button>
)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
}
value={`${Math.round(value * 100)}%`}
minValue={1}
Expand Down