Skip to content

chore: apply follow-up fixes for recently merged commits - #13914

Open
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-08-04
Open

chore: apply follow-up fixes for recently merged commits#13914
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-08-04

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-08-03 17:46 (PT) and 2026-08-04 00:05 (PT) (efa3ea81f6aa3d), from an automated review of the last 24 hours of merged commits.

This pull request:

blas/ext/base/ztriu

  • Fix .js extension in two require() calls introduced by ee75563 (blas/ext/base/ztriu): lib/main.js's require( './ztriu' ) and test/test.ztriu.js's require( './../lib/ztriu' ). Both violate stdlib/require-file-extensions; dtriu, striu, and ctriu's lib/main.js already do this correctly.

blas/ext/base/ctriu

  • Fix require path in test/test.ctriu.js: commit ed05eba added blas/ext/base/ctriu but left the extensionless require( './../lib/ctriu' ), tripping the error-level stdlib/require-file-extensions rule that lib/main.js and the dtriu/striu siblings already honor. Change to require( './../lib/ctriu.js' ).

complex/float32/base/div

  • Removes the inapplicable References section from complex/float32/base/div's README.md (Smith 1962, Stewart 1985, Priest 2004), copied from complex/float64/base/div in b423804. Per lib/assign.js/src/main.c, this package follows Julia's promote-to-double approach and doesn't use those scaling algorithms, so the citations don't apply.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation. All 21 commits in the window were reviewed by two independent style-compliance passes (checked against docs/style-guides and established sibling packages: dtriu/striu, mprod/mvariance/wmean and the nanm* family, complex/float64/base/div) and two independent bug-scan passes over the diffs (loop bounds, stride/offset arithmetic, complex interleaving, accumulator delegation, namespace wiring). Every fix in this PR was re-verified against the checked-out files before committing; each fix touches only lines added in the window.

Deliberately excluded (require interpretation or a maintainer decision, not mechanical fixes):

  • complex/float32/base/div returns signed zeros whose signs differ from complex/float64/base/div for finite/infinite division (e.g. (5+3i)/(Inf+1i) yields (+0, -0) in float32 vs (+0, +0) in float64, and signed zeros instead of NaNs when both denominator components are infinite). The divergence is reproducible, but the package's own tests assert the current behavior, so this is left as a design question rather than patched here.
  • stats/incr/nanmprod docs say values are "calculated from all provided values" without the "(excluding NaN values)" qualifier that nanmvariance/nanmrmse (same batch) use — but established nanm* packages (nanmsum, nanmmax, nanmmin) use the same unqualified wording, so which wording is canonical is left to maintainers.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was authored by Claude Code as part of a scheduled automated review of commits merged to develop in the last 24 hours; all fixes were machine-proposed, cross-verified by independent review passes, and re-checked against the repository before committing.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GNzxG7FaJDiXSfWgnYz8Eh


Generated by Claude Code

@Planeshifter Planeshifter changed the title Follow-up fixes for commits merged to develop on 2026-08-03/04 chore: apply follow-up fixes for recently merged commits Aug 4, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ctriu $\\color{green}584/584$
$\\color{green}+100.00\\%$
$\\color{green}43/43$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}584/584$
$\\color{green}+100.00\\%$
blas/ext/base/ztriu $\\color{green}584/584$
$\\color{green}+100.00\\%$
$\\color{green}43/43$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}584/584$
$\\color{green}+100.00\\%$
complex/float32/base/div $\\color{green}325/325$
$\\color{green}+100.00\\%$
$\\color{green}15/15$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}325/325$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
Planeshifter marked this pull request as ready for review August 4, 2026 14:10
@Planeshifter
Planeshifter requested review from a team and kgryte August 4, 2026 14:10
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants