chore: apply follow-up fixes for recently merged commits - #13914
Open
Planeshifter wants to merge 3 commits into
Open
chore: apply follow-up fixes for recently merged commits#13914Planeshifter wants to merge 3 commits into
Planeshifter wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GNzxG7FaJDiXSfWgnYz8Eh
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GNzxG7FaJDiXSfWgnYz8Eh
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GNzxG7FaJDiXSfWgnYz8Eh
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-03 17:46 (PT) and 2026-08-04 00:05 (PT) (efa3ea8…1f6aa3d), from an automated review of the last 24 hours of merged commits.This pull request:
blas/ext/base/ztriu.jsextension in tworequire()calls introduced by ee75563 (blas/ext/base/ztriu):lib/main.js'srequire( './ztriu' )andtest/test.ztriu.js'srequire( './../lib/ztriu' ). Both violatestdlib/require-file-extensions;dtriu,striu, andctriu'slib/main.jsalready do this correctly.blas/ext/base/ctriurequirepath intest/test.ctriu.js: commit ed05eba addedblas/ext/base/ctriubut left the extensionlessrequire( './../lib/ctriu' ), tripping the error-levelstdlib/require-file-extensionsrule thatlib/main.jsand thedtriu/striusiblings already honor. Change torequire( './../lib/ctriu.js' ).complex/float32/base/divcomplex/float32/base/div'sREADME.md(Smith 1962, Stewart 1985, Priest 2004), copied fromcomplex/float64/base/divin b423804. Perlib/assign.js/src/main.c, this package follows Julia's promote-to-double approach and doesn't use those scaling algorithms, so the citations don't apply.Related Issues
No.
Questions
No.
Other
Validation. All 21 commits in the window were reviewed by two independent style-compliance passes (checked against
docs/style-guidesand established sibling packages:dtriu/striu,mprod/mvariance/wmeanand thenanm*family,complex/float64/base/div) and two independent bug-scan passes over the diffs (loop bounds, stride/offset arithmetic, complex interleaving, accumulator delegation, namespace wiring). Every fix in this PR was re-verified against the checked-out files before committing; each fix touches only lines added in the window.Deliberately excluded (require interpretation or a maintainer decision, not mechanical fixes):
complex/float32/base/divreturns signed zeros whose signs differ fromcomplex/float64/base/divfor finite/infinite division (e.g.(5+3i)/(Inf+1i)yields(+0, -0)in float32 vs(+0, +0)in float64, and signed zeros instead of NaNs when both denominator components are infinite). The divergence is reproducible, but the package's own tests assert the current behavior, so this is left as a design question rather than patched here.stats/incr/nanmproddocs say values are "calculated from all provided values" without the "(excludingNaNvalues)" qualifier thatnanmvariance/nanmrmse(same batch) use — but establishednanm*packages (nanmsum,nanmmax,nanmmin) use the same unqualified wording, so which wording is canonical is left to maintainers.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a scheduled automated review of commits merged to
developin the last 24 hours; all fixes were machine-proposed, cross-verified by independent review passes, and re-checked against the repository before committing.🤖 Generated with Claude Code
https://claude.ai/code/session_01GNzxG7FaJDiXSfWgnYz8Eh
Generated by Claude Code