Agent review#136
Merged
Merged
Conversation
Update the Container Interface paper to match the implementation: document the shared basic_edge concept (source_id + target_id) and the adj_list edge refinement that adds source/target descriptors, with basic_sourced_edgelist resting on basic_edge. Add agents/D3130_review.md capturing the full code-vs-paper review and open questions.
edge_storage_type is always EdgeIter (edges are backed by a physical container, so there is no index-only edge path). Update the descriptor.hpp snippet, the descriptor-storage prose, and scope the size claims so 'one integer' applies to the index-based vertex_descriptor while an edge_descriptor is an iterator plus the source vertex_descriptor. Resolves review item 1.2.
The edgelist vertex_id_t<EL> and raw-vertex-id-type are derived from source_id(el,uv), matching edge_list.hpp. Update the type-alias table and the namespace prose (previously referenced target_id). Resolves review item 1.3 / Q4.
vertex_id_store_t<G> was listed as 'normative' with an undefined '(see below)' definition but has no counterpart in the implementation. Remove it from the type-alias table and the revision history; retain the valid raw-vertex-id-type exposition-only alias (raw_vertex_id_t<G> in code). Resolves review item 1.4.
…ation' Mark the adjacency_matrix trait family and its constant-time contains_out_edge branch (1.5), the partition-filtered out_edges(g,*,pid) overloads (1.6), and the edgelist num_edges/has_edges/contains_edge functions (1.7) as future design not yet in the reference implementation. Resolves review items 1.5-1.7 / Q1-Q3.
…n defaults - Add hashable_vertex_id concept and include it in mapped_vertex_range (1.9/Q5) - Add is_vertex_descriptor_v guard to the vertex<G,V> concept snippet + prose (1.10) - Clarify partition vertices(g,pid)/num_vertices(g,pid) defaults are pid==0 only (2.1) - Document num_edges(g,u)/num_edges(g,uid) as aliases for out_degree (2.2) Resolves review items 1.9, 1.10, 2.1, 2.2, 2.3 / Q5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.