Feat: Significant performance improvements across all mass taggers#718
Closed
Servbot91 wants to merge 1 commit into
Closed
Feat: Significant performance improvements across all mass taggers#718Servbot91 wants to merge 1 commit into
Servbot91 wants to merge 1 commit into
Conversation
|
This pull request has been mentioned on Stash Forum. There might be relevant details there: https://discourse.stashapp.cc/t/tag-images-from-galleries/6024/5 |
Contributor
|
Could you split this into separate PRs? It's updating 3 plugins from 3 different authors and adding a new one on top of that. |
Contributor
Author
|
I mean, i could. Though im not sure what difference it makes outside of polluting commit history for plugins that have been practically abandoned and creating more work for me simply for the sake of it.
Sent from Mobile🚄
…-------- Original Message --------
On Thursday, 05/28/26 at 23:40 DogmaDragon ***@***.***> wrote:
DogmaDragon left a comment [(stashapp/CommunityScripts#718)](#718 (comment))
Could you split this into separate PRs? It's updating 3 plugins from 3 different authors and adding a new one on top of that.
—
Reply to this email directly, [view it on GitHub](#718?email_source=notifications&email_token=BT2T5GJ3BSRLP525NPUDI4L45EBBLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJXGAZDMNZQGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4570267005), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BT2T5GKMCEQV5WXUJJWBHB345EBBLAVCNFSM6AAAAACZRZQULGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKNZQGI3DOMBQGU).
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for [iOS](https://github.com/notifications/mobile/ios/BT2T5GNFQFDZF3J6P7EDWTL45EBBLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJXGAZDMNZQGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG) and [Android](https://github.com/notifications/mobile/android/BT2T5GP7EHP54FC5SHHIQL345EBBLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJXGAZDMNZQGA22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA). Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
|
Contributor
Author
|
If that is how you believe things should be then that is fine. I will go ahead and maintain these on my own.
The bureaucracy involved with submitting changes to this repo seems to continuously create more work than its worth for me. For plugins with inconsistent or no quality control that are basically abandoned, it seems much easier for me to address these problems without a middle man. You can reject the pr.
Sent from Mobile🚄
…-------- Original Message --------
On Friday, 05/29/26 at 21:39 DogmaDragon ***@***.***> wrote:
DogmaDragon left a comment [(stashapp/CommunityScripts#718)](#718 (comment))
- It makes review process harder.
- If there are needed changes, it will block the whole PR even if only one plugin is affected.
- We give original authors a chance to review PRs targetting their plugins, which will delay the merge of whole PR instead of only affected plugin,
- I prefer clear and conside PRs for adding new plugins as it makes tracking commit history a lot easier down the line and to avoid license issue with https://github.com/Servbot91/StashAPP-TagImagesFromGalleries/tree/main/plugins/tagImagesFromGalleries version which doesn't have any license.
—
Reply to this email directly, [view it on GitHub](#718?email_source=notifications&email_token=BT2T5GOV6F34Q6NEDWQLXC345I3UXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJYGEYTQNZVGI22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4581187525), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BT2T5GJEMZMHIGG57L5QAZ345I3UXAVCNFSM6AAAAACZRZQULGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKOBRGE4DONJSGU).
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for [iOS](https://github.com/notifications/mobile/ios/BT2T5GOB6ZF6A75AK4JQSLT45I3UXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJYGEYTQNZVGI22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG) and [Android](https://github.com/notifications/mobile/android/BT2T5GLTGMMRRZ3FQDMQGLT45I3UXA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJYGEYTQNZVGI22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA). Download it today!
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
We don't see having license complience and giving original authors an opportunity to review changes before they are pushed as bureaucracy, but it's fair if that's too much for you. |
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev Notes
These changes provide on average about a 95% performance improvement to all 4 mass taggers. I have tested these individually and running concurrently without issue. Mass tagging galleries, images, and scenes has dramatically increased. The previous logic did not properly use the schema which caused the DB to get absolutely blasted with "slow query" messages in debug.
If running these plugins concurrently, they would ping pong off each other causing loops further running away with your DB's performance. You also had the issue of the scripts reiterating over files they should be ignoring which also contributed to unnecessary load. If your database size is significant or you have large galleries this could bring your DB to its knees and would basically require you to run these tasks over night.
For using the 'Tag all galleries from images' feature, I have gone from over 2 days ETA to 40 minutes across 2.5 million images.
'Tag Images with performer' tags of 5k+ performers has been reduced to less than 30 minutes down from 7 hours.
'Tag all images from galleries' (80k + galleries) is down from 14 hours to 40 minutes.
'Tag all scenes' (20k+) went from 4 hours to 20 minutes.
These changes maintain core logic while also improving performance. User performance will vary, but at the very least the scripts are running significantly more optimal than they were before.
-Sakoto
These images demonstrate that no more slow queries display under load with all taggers running in tandem and a mass tagger running.
Changes