Skip to content

feat(sfs): add labels to sfs resources - #1430

Merged
Manuelvaas merged 2 commits into
mainfrom
feature/add-labels-to-sfs-resources
May 18, 2026
Merged

feat(sfs): add labels to sfs resources#1430
Manuelvaas merged 2 commits into
mainfrom
feature/add-labels-to-sfs-resources

Conversation

@Manuelvaas

@Manuelvaas Manuelvaas commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Description

relates to STACKITTPR-525

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@Manuelvaas
Manuelvaas requested a review from a team as a code owner April 27, 2026 16:35
@Manuelvaas
Manuelvaas force-pushed the feature/add-labels-to-sfs-resources branch from 942fc7e to 6b8c3f8 Compare April 28, 2026 07:57
@Manuelvaas
Manuelvaas enabled auto-merge (squash) April 28, 2026 07:59
@Manuelvaas Manuelvaas changed the title feat(sfs): add labels to share and resource pool feat(sfs): add labels to sfs resources Apr 28, 2026
Comment thread stackit/internal/services/sfs/resourcepool/resource.go Outdated
@Manuelvaas
Manuelvaas disabled auto-merge April 30, 2026 08:28
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions Bot added the Stale PR is marked as stale due to inactivity. label May 8, 2026
@Manuelvaas Manuelvaas removed the Stale PR is marked as stale due to inactivity. label May 12, 2026
@Manuelvaas
Manuelvaas force-pushed the feature/add-labels-to-sfs-resources branch 2 times, most recently from c405e64 to fd88279 Compare May 18, 2026 09:07
Comment thread stackit/internal/services/sfs/export-policy/datasource.go Outdated
Comment thread stackit/internal/validate/labels_test.go Outdated
Comment thread stackit/internal/validate/labels_test.go Outdated
Comment thread stackit/internal/validate/labels_test.go Outdated
Comment thread stackit/internal/utils/labels_test.go
@GokceGK

GokceGK commented May 18, 2026

Copy link
Copy Markdown
Contributor

Can you add labels also to examples please? :)

@Manuelvaas
Manuelvaas force-pushed the feature/add-labels-to-sfs-resources branch from 174e90a to 9442417 Compare May 18, 2026 14:36
@Manuelvaas
Manuelvaas force-pushed the feature/add-labels-to-sfs-resources branch from 9442417 to 66d6144 Compare May 18, 2026 14:36
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/export-policy 20.00% (+1.72%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool 23.01% (+2.09%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share 14.47% (+2.75%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils 86.67% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/validate 97.12% (+0.03%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/export-policy/datasource.go 0.00% (ø) 47 0 47
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/export-policy/resource.go 23.72% (+1.90%) 253 (+10) 60 (+7) 193 (+3) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/datasource.go 35.00% (+2.11%) 80 (+4) 28 (+3) 52 (+1) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/resource.go 19.31% (+2.04%) 259 (+10) 50 (+7) 209 (+3) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/datasource.go 25.35% (+2.96%) 71 (+4) 18 (+3) 53 (+1) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/resource.go 11.16% (+2.64%) 233 (+10) 26 (+7) 207 (+3) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/labels.go 86.67% (+86.67%) 15 (+15) 13 (+13) 2 (+2) 🌟
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/validate/labels.go 100.00% (+100.00%) 1 (+1) 1 (+1) 0 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/export-policy/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/resourcepool/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/sfs_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/datasource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/sfs/share/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/utils/labels_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/validate/labels_test.go

@Manuelvaas
Manuelvaas enabled auto-merge (squash) May 18, 2026 14:41
@Manuelvaas
Manuelvaas merged commit 60a9645 into main May 18, 2026
3 checks passed
@Manuelvaas
Manuelvaas deleted the feature/add-labels-to-sfs-resources branch May 18, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants