feat(ci): add custom linter to prevent stuttering in pkg paths#7279
Open
rubenhoenle wants to merge 1 commit into
Open
feat(ci): add custom linter to prevent stuttering in pkg paths#7279rubenhoenle wants to merge 1 commit into
rubenhoenle wants to merge 1 commit into
Conversation
2fe7cac to
49d63ee
Compare
Member
Author
|
Failing pipline maybe related to golangci/golangci-lint#6205 |
11 tasks
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
rubenhoenle
added a commit
that referenced
this pull request
Jun 2, 2026
49d63ee to
3af2c94
Compare
cgoetz-inovex
approved these changes
Jun 2, 2026
| cd ${SERVICES_PATH}/${service} | ||
| if [ "${SKIP_NON_GENERATED_FILES}" = true ]; then | ||
| golangci-lint run ${GOLANG_CI_ARGS} --skip-dirs wait # All manually maintained files are in subfolders | ||
| ${ROOT_DIR}/custom-gcl run ${GOLANG_CI_ARGS} --skip-dirs wait # All manually maintained files are in subfolders |
Contributor
There was a problem hiding this comment.
Suggested change
| ${ROOT_DIR}/custom-gcl run ${GOLANG_CI_ARGS} --skip-dirs wait # All manually maintained files are in subfolders | |
| # do nothing, golangci-lint does not lint generated files, so this option means do not lint at all |
also skip-dirs has been removed: https://golangci-lint.run/docs/product/migration-guide/#runskip-dirs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to #7276
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)