feat: Allow tweaking catalog name in Trino#903
Open
sbernauer wants to merge 1 commit into
Open
Conversation
9a938a3 to
e306fc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #891
Sadly we could not agree on the custom part (yet), so we keep that for the later.
I also included two things:
TrinoCatalogName, which is a new type wrapper aroundStringVec<CatalogConfig>toBTreeMap<TrinoCatalogName, CatalogConfig>so that it's guaranteed we never end up with the same catalog name twiceDefinition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features trackerRelease notes
Add a new
.spec.name.inferred.replaceHyphensWithUnderscoresfield on TrinoCatalog, which allows tweaking the catalog name in Trino by replacing-with_. This allows you to use valid Kubernetes names, but keeps the convenience of_in catalog names.