fix build with .NET 9.0 SDK#1427
Merged
Merged
Conversation
see dotnet/roslyn-analyzers#7208 Most of these could be safely ignored because of the following assert. As far as I can see, The SftpFileStream.Read() implementation guarentees that the specified number of bytes is read anyway.
mus65
requested review from
Rob-Hague,
WojciechNagorski and
drieseng
as code owners
Rob-Hague
approved these changes
Jun 16, 2024
Rob-Hague
left a comment
Rob-Hague
left a comment
Collaborator
There was a problem hiding this comment.
Thanks
One day we'll stop every diagnostic being an error ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSH.NET is currently not buildable with .NET 9 because of newly introduced warnings CA1872 and CA2022, see separate commits.