Added configurable maxFramePayloadLength to ReactorNettyWebSocketClient

[envious]

Currently the ReactorNettyWebSocketClient (RNWSC) doesn't allow for a configurable maxFramePayloadLength. The HttpClient used by the RNWSC allows for a configurable maxFramePayloadLength however, the method .websocket() used by the RNWSC ignores whatever is set by the HttpClient and uses a default value of 65536. As shown below:

ReactorNettyWebSocketClient invokes .websocket()

.websocket(StringUtils.collectionToCommaDelimitedString(handler.getSubProtocols()))

The method invoked on the HttpClient ignores the value you may have set in your HttpClient

public final WebsocketSender websocket(String subprotocols) {
	return websocket(subprotocols, 65536);
}

I've solved the issue by using the overloaded .websocket() method on the HttpClient which takes a maxFramePayloadLength.

.websocket(StringUtils.collectionToCommaDelimitedString(handler.getSubProtocols()), 
getMaxFramePayloadLength())

The maxFramePayloadLength is now configurable in the RNWSC.

[philsttr]

I noticed that this PR did not change ReactorNettyWebSocketClient to call the constructor for ReactorNettyWebSocketSession that takes the maxFramePayloadLength

It seems odd that the ReactorNettyWebSocketSession.maxFramePayloadLength is not set on the client side, but is set on the server-side. i.e. ReactorNettyWebSocketSession.maxFramePayloadLength will keep the default value (64k) on the client side regardless of how ReactorNettyWebSocketClient.maxFramePayloadLength is configured.

Is this intended?

Will something bad happen if ReactorNettyWebSocketClient.maxFramePayloadLength has a different value than ReactorNettyWebSocketSession.maxFramePayloadLength ?

[rstoyanchev]

Good catch @philsttr, thanks.

[eliquinox]

Is it possible to use this feature now or do we have to wait for the milestone?