Fix: Display raw username in LogEvent admin when user is None (#337) - #338
Merged
Conversation
jheld
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #337 where the "User name" column in the
LoginEventadmin list appears empty for failed login attempts when the user does not exist.Previously,
get_usernamereturnedNoneif theuserobject was missing. I have updated the logic to fall back to the rawobj.usernamestored in the log event, ensuring the attempted username is always visible.Changes
LoginEventAdmin.get_usernameineasyaudit/admin.py.self.get_user(obj)returnsNone(e.g., failed login with invalid user), the method now returnsobj.username.Testing
pytestlocally (All tests passed).