Drop support for sonata-project/block-bundle 4#8344
Merged
VincentLanglet merged 1 commit intosonata-project:4.xfrom Oct 29, 2025
Merged
Drop support for sonata-project/block-bundle 4#8344VincentLanglet merged 1 commit intosonata-project:4.xfrom
VincentLanglet merged 1 commit intosonata-project:4.xfrom
Conversation
dmaicher
force-pushed
the
drop_block_bundle_4
branch
from
d7c390b to
5a034a3
Compare
|
|
||
| $blockExtension = new SonataBlockExtension(); | ||
| /* | ||
| * TODO: remove "http_cache" parameter when support for SonataBlockBundle 4 is dropped. |
Member
There was a problem hiding this comment.
I'm not sure to understand the comment @dmaicher, shouldn't we keep
$blockExtension->load(['sonata_block' => []], $container);
or it's a useless call ?
Contributor
Author
There was a problem hiding this comment.
well tests are passing 😄 So I think it was a useless call. No need to load the extension. This was just loaded to prevent a deprecation I believe.
VincentLanglet
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because its BC.
Let's drop support for v4 to simplify things. Will also look into dropping support for other unmaintained sonata package versions as well.
Changelog