Skip to content

Amend simd 0376 ed25519-zebra verification - #616

Open
zz-sol wants to merge 4 commits into
solana-foundation:mainfrom
zz-sol:zz/fix_simd_0376
Open

Amend simd 0376 ed25519-zebra verification#616
zz-sol wants to merge 4 commits into
solana-foundation:mainfrom
zz-sol:zz/fix_simd_0376

Conversation

@zz-sol

@zz-sol zz-sol commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This PR amends the 0376 signature verification.

Prior to this PR, simd-0376 uses purely zebra verification as per zip215. It is reported that zip215 deliberately allows for zero-encoded public key (this is not an issue for zcash as they do not use public keys for other purposes) which means, an attacker can forge signatures for any messages for a zero key (i.e. Pubkey::default()), widely used as a "disabled authority" sentinel.

We propose to use "reject small-order A" variant from the Taming the many EdDSAs paper instead of pure ZIP-215. Speficially

  • reject non-canonical encodings of A and R,
  • reject non-reduced S,
  • reject small-order A and R,
  • keep the cofactored equation as in zip-215.

@simd-bot

simd-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

Hello zz-sol! Welcome to the SIMD process. By opening this PR you are affirming that your SIMD has been thoroughly discussed and vetted in the SIMD discussion section. The SIMD PR section should only be used to submit a final technical specification for review. If your design / idea still needs discussion, please close this PR and create a new discussion here.

This PR requires the following approvals before it can be merged:

Once all requirements are met, you can merge this PR by commenting /merge.

@zz-sol zz-sol changed the title Amend simd 0376 Amend simd 0376 ed25519-zebra verification Sep 1, 2026
@zz-sol

zz-sol commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

tagging @robre @samkim-crypto @Rexicon226 for review

@robre

robre commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants