Amend simd 0376 ed25519-zebra verification - #616
Open
zz-sol wants to merge 4 commits into
Open
Conversation
|
Hello zz-sol! Welcome to the SIMD process. By opening this PR you are affirming that your SIMD has been thoroughly discussed and vetted in the SIMD discussion section. The SIMD PR section should only be used to submit a final technical specification for review. If your design / idea still needs discussion, please close this PR and create a new discussion here. This PR requires the following approvals before it can be merged:
Once all requirements are met, you can merge this PR by commenting |
zz-sol
force-pushed
the
zz/fix_simd_0376
branch
from
September 1, 2026 09:46
8e3ce91 to
36a683d
Compare
zz-sol
force-pushed
the
zz/fix_simd_0376
branch
from
September 1, 2026 09:57
e595754 to
56f7137
Compare
Contributor
Author
|
tagging @robre @samkim-crypto @Rexicon226 for review |
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR amends the 0376 signature verification.
Prior to this PR, simd-0376 uses purely zebra verification as per zip215. It is reported that zip215 deliberately allows for zero-encoded public key (this is not an issue for zcash as they do not use public keys for other purposes) which means, an attacker can forge signatures for any messages for a zero key (i.e.
Pubkey::default()), widely used as a "disabled authority" sentinel.We propose to use "reject small-order A" variant from the Taming the many EdDSAs paper instead of pure ZIP-215. Speficially