Skip to content

SIMD-0582: Early detection of instruction trace overflow - #582

Open
LucasSte wants to merge 3 commits into
solana-foundation:mainfrom
LucasSte:fail-early
Open

SIMD-0582: Early detection of instruction trace overflow#582
LucasSte wants to merge 3 commits into
solana-foundation:mainfrom
LucasSte:fail-early

Conversation

@LucasSte

@LucasSte LucasSte commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@simd-bot

simd-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

Hello LucasSte! Welcome to the SIMD process. By opening this PR you are affirming that your SIMD has been thoroughly discussed and vetted in the SIMD discussion section. The SIMD PR section should only be used to submit a final technical specification for review. If your design / idea still needs discussion, please close this PR and create a new discussion here.

This PR requires the following approvals before it can be merged:

Once all requirements are met, you can merge this PR by commenting /merge.

@LucasSte
LucasSte force-pushed the fail-early branch 2 times, most recently from a5d5d0c to d8fcd55 Compare July 14, 2026 21:39
@LucasSte LucasSte changed the title Early detection of instruction trace overflow SIMD-0582: Early detection of instruction trace overflow Jul 14, 2026
buffalojoec
buffalojoec reviewed Jul 17, 2026
View reviewed changes

@buffalojoec buffalojoec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself makes sense to me! Let's just tighten up the design language and the motivation, then get it in.

This is a win for performance.

Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
@github-actions github-actions Bot mentioned this pull request Jul 20, 2026
Open
mjain-jump
mjain-jump approved these changes Aug 14, 2026
View reviewed changes

@mjain-jump mjain-jump left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@simd-bot

simd-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

Thanks, topointon-jump!

⚠️ Status: Cannot merge yet

buffalojoec
buffalojoec reviewed Aug 24, 2026
View reviewed changes
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
Comment thread proposals/0582-instruction-cpi-limit.md Outdated
buffalojoec
buffalojoec approved these changes Aug 26, 2026
View reviewed changes

@buffalojoec buffalojoec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for addressing my feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes
+2 more reviewers
@mjain-jump mjain-jump mjain-jump approved these changes
@topointon-jump topointon-jump topointon-jump approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LucasSte @buffalojoec @mjain-jump @topointon-jump