feat(ws): support dataSlice in AccountSubscribe - #433
Merged
HealthyBuilder merged 1 commit intoMay 25, 2026
Merged
Conversation
Add AccountSubscribeOpts and AccountSubscribeWithConfig to mirror the
optional configuration object the accountSubscribe RPC method accepts,
including the missing dataSlice parameter. dataSlice asks the
validator to return only the requested slice of the account's data
field, which is useful for large accounts where the caller only needs
a known-offset region (program account headers, discriminators, fixed
header fields, etc.).
The existing AccountSubscribeWithOpts(account, commitment, encoding)
entry point delegates to the new opts form, so existing callers are
not affected.
Adds wire-shape tests covering: defaults, dataSlice JSON shape
({"offset": N, "length": N}), and the encoding override path.
Collaborator
|
Same pattern as #432 approving One non-blocking nit: ended up with AccountSubscribeWithOpts (old, 3-arg) + AccountSubscribeWithConfig (new, opts-struct) coexisting. We could clean this up later by deprecating the old one with a // Deprecated: comment pointing readers at the new entry point — happy to track that as a follow-up issue rather than block this PR. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
AccountSubscribeOpts+AccountSubscribeWithConfigto mirror the optional configuration object theaccountSubscribeRPC method accepts, including the missingdataSliceparameter.dataSliceasks the validator to return only the requested{offset, length}slice of the account's data field. Useful for large accounts where the caller only needs a known-offset region (program account headers, discriminators, fixed header fields, etc.) — without it, every notification carries the full account data over the wire.What changed
AccountSubscribeOpts { Commitment, Encoding, DataSlice }.AccountSubscribeWithConfig(account, opts)carries the full opts object through to the request body.AccountSubscribeWithOpts(account, commitment, encoding)is preserved by delegating to the new opts form, andAccountSubscribe(account, commitment)is unchanged.Test plan
go build ./...go test ./...accountSubscribe_test.goasserts: defaults (encoding=base64, no commitment, no dataSlice),dataSliceJSON shape{\"offset\":N,\"length\":N}, and the encoding override path