Skip to content

fix: Chrome debugger crash caused by incorrect viewTag #6437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatiPl01 merged 2 commits into from
Aug 21, 2024
Merged

fix: Chrome debugger crash caused by incorrect viewTag #6437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b7e52e
Fix chrome debugger crash caused by incorrect viewTag
MatiPl01 Aug 21, 2024
a6b4b78
Store shouldBeUseWeb result in constant
MatiPl01 Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/react-native-reanimated/src/createAnimatedComponent/createAnimatedComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ import type { ReanimatedHTMLElement } from '../js-reanimated';

const IS_WEB = isWeb();
const IS_JEST = isJest();
const SHOULD_BE_USE_WEB = shouldBeUseWeb();

if (IS_WEB) {
configureWebLayoutAnimations();
Expand Down Expand Up @@ -289,7 +290,7 @@ export function createAnimatedComponent(
? (this._component as AnimatedComponentRef).getAnimatableRef?.()
: this;

if (IS_WEB) {
if (SHOULD_BE_USE_WEB) {
// At this point I assume that `_setComponentRef` was already called and `_component` is set.
// `this._component` on web represents HTMLElement of our component, that's why we use casting
viewTag = this._component as HTMLElement;
Expand Down Expand Up @@ -501,7 +502,7 @@ export function createAnimatedComponent(
(layout || entering || exiting || sharedTransitionTag) &&
tag != null
) {
if (!shouldBeUseWeb()) {
if (!SHOULD_BE_USE_WEB) {
enableLayoutAnimations(true, false);
}

Expand Down