Skip to content

Fix unused setter argument warning - #22

Merged
soffes merged 1 commit into
soffes:masterfrom
msanders:ms/unused-setter-argument
Jun 2, 2023
Merged

Fix unused setter argument warning#22
soffes merged 1 commit into
soffes:masterfrom
msanders:ms/unused-setter-argument

Conversation

@msanders

@msanders msanders commented Feb 2, 2020

Copy link
Copy Markdown
Contributor

Fixes:

Sources/HotKey/KeyCombo.swift:26:22: warning: setter argument 'newValue' was never used, but the property was accessed
                        carbonModifiers = modifiers.carbonFlags
                                          ^
Sources/HotKey/KeyCombo.swift:26:22: note: did you mean to use 'newValue' instead of accessing the property's current value?
                        carbonModifiers = modifiers.carbonFlags
                                          ^~~~~~~~~
                                          newValue

@wlisac

wlisac commented Feb 18, 2020

Copy link
Copy Markdown

I'm seeing the same warning. Would love to see this make it in.

@puliaiev

Copy link
Copy Markdown

I was about to create a PR and found yours 😁.

@soffes
soffes merged commit 581114d into soffes:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants