Add scoped signal events.#67
Open
samuel-williams-shopify wants to merge 23 commits into
Open
Conversation
6a3953d to
ed4e292
Compare
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
ed4e292 to
02ce566
Compare
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
86fb228 to
46b6dcb
Compare
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
46b6dcb to
8001225
Compare
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
This reverts commit 6ad1df3. Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
e905899 to
9986da8
Compare
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
6202cdd to
d16f67d
Compare
a70fa54 to
3c973ab
Compare
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
3c973ab to
b8b72d5
Compare
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async-signalsfor scoped controller signal trap installation instead of the localAsync::Container::Signalshelper.Controller::SignalEventobjects so trap handlers only wake the controller event loop.Async::Container::Events, a pipe-backedThread::Queuewrapper that can wakeIO.select.IO#write_nonblock(..., exception: false)andIO#read_nonblock(..., exception: false).GC.startworkaround now thatio-eventv1.17.0 fixes inherited selector ownership after fork.Testing
/Users/samuel/.local/state/tec/toolchain/base_profile/bin/bundle exec sus test/async/container/controller.rb/Users/samuel/.local/state/tec/toolchain/base_profile/bin/bundle exec sus/Users/samuel/.local/state/tec/toolchain/base_profile/bin/bundle exec bake test:external