fix(snyk): remediate high-and-above vulnerabilities on feat/CLI-1813_optimize_feature_flags - #743
Open
prodsec-github-automation wants to merge 1 commit into
Conversation
…ource Applied by snyk fix --agentic via the Snyk ProdSec CircleCI orb, from feat/CLI-1813_optimize_feature_flags at fcedb22. These changes are generated. Review them before merging.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
| Status | Scan Engine | Total (0) | ||||
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details | |
| Licenses | 0 | 0 | 0 | 0 | See details | |
| ✅ | Code Security | 0 | 0 | 0 | 0 | 0 issues |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
PR Reviewer Guide 🔍
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk agentic fix
The Snyk Open Source scan of
feat/CLI-1813_optimize_feature_flagsreported vulnerabilities at or above high severity. This branch was produced bysnyk fix --agenticworking on those.Whether that scan also failed the build depends on the Enhanced Gate, which blocks only once a vulnerability has passed its remediation SLA — so this pull request may exist for a build that is green.
5 of 5 fixed.
Fixed
go.modgolang.org/x/cryptoandgolang.org/x/net. No breaking API changes are documented, and the risk to typical application behavior is low. Key Changes: - Security: Rejects path traversal in reference names to prevent vulnerabilities. - Security: Hardens the worktree filesystem against symlink-related issues. - Fix: Corrects how index entries are stored on Windows. Source: GitHub Release v5.19.2go.modv5.19.1tov5.19.2. The release contains security updates and bug fixes. Key Changes: - Updates to dependencies such asgolang.org/x/cryptoandgolang.org/x/netfor security purposes. [1] - A security fix to reject path traversal in reference names. [1] - A bug fix for handling backslashes in index entries on Windows. [1] There are no documented breaking API changes in this patch release. The changes are focused on improving security and fixing platform-specific bugs. Source: GitHub Release Notesgo.modstorage/filesystem/dotgitpackage is the introduction of stricter validation to reject path traversal in reference names. While this is a security enhancement, it is a behavioral change that could cause issues if an application was inadvertently relying on the previous, less strict validation. This change elevates the risk to medium, as it may require verification. Other changes include dependency updates and a fix for handling backslashes on Windows. Recommendation: Verify that any logic creating or handling git reference names does not rely on paths that could now be rejected as traversal attempts.go.modgolang.org/x/crypto/sshthat addresses two Denial of Service (DoS) vulnerabilities. Key Changes: - CVE-2026-56855: Fixes a deadlock vulnerability where a malicious peer could hang an established connection. The server will now treat certain malformed messages as a protocol error and terminate the connection instead of blocking. - CVE-2026-78662: Fixes a deadlock vulnerability on channels that are not yet fully established. The server will now drop unexpected packets on these channels without blocking. Risk Assessment: This upgrade is assessed as medium risk. While these are critical security fixes, the change in error handling—specifically, tearing down connections upon protocol errors where they might have previously hung—is a behavioral change. Systems with non-compliant or custom SSH clients may experience unexpected connection drops that require verification. Source: Security Announcementgo.modgolang.org/x/crypto/sshthat addresses two Denial of Service (DoS) vulnerabilities. Key Changes: - CVE-2026-56855: Fixes a deadlock vulnerability where a malicious peer could hang an established connection. The server will now treat certain malformed messages as a protocol error and terminate the connection instead of blocking. - CVE-2026-78662: Fixes a deadlock vulnerability on channels that are not yet fully established. The server will now drop unexpected packets on these channels without blocking. Risk Assessment: This upgrade is assessed as medium risk. While these are critical security fixes, the change in error handling—specifically, tearing down connections upon protocol errors where they might have previously hung—is a behavioral change. Systems with non-compliant or custom SSH clients may experience unexpected connection drops that require verification. Source: Security AnnouncementThis is not necessarily a complete fix. The build on this pull request runs the same Open Source scan and quality gate, so its result — not this description — is the verdict on what is left.
Changes
Snyk ProdSec orb · build 21227 · model
claude-opus-4-8Note
Medium Risk
Patch upgrades fix critical Git traversal/symlink and SSH DoS issues but change validation and SSH error handling; verify Git/SSH paths if the framework or its deps exercise them in production.
Overview
Dependency-only update to
go.mod/go.sumfrom Snyk agentic remediation (5 high-severity issues). No application source changes.Direct bumps:
github.com/go-git/go-git/v5v5.19.1 → v5.19.2, plusgolang.org/x/mod,golang.org/x/text, and indirectgolang.org/x/cryptoandgolang.org/x/tools.go-git v5.19.2 hardens Git operations: rejects path traversal in reference names, symlink-safe worktree filesystem behavior, and related fixes in plumbing/storage paths that addressed the reported traversal and symlink issues.
golang.org/x/crypto (SSH) picks up DoS/deadlock fixes that may terminate connections on malformed protocol traffic instead of hanging—relevant only where SSH from this dependency tree is used at runtime.
Reviewers should treat this like any security patch bump: confirm changelogs and that Git reference naming or custom SSH clients are not relying on pre-fix behavior.
Reviewed by Cursor Bugbot for commit 8b7530d. Bugbot is set up for automated code reviews on this repo. Configure here.