Skip to content

feat: add unmanaged service test call ff - #3603

Merged
dagrest merged 1 commit into
masterfrom
feat/add-unmanaged-service-test-call-ff
Sep 20, 2022
Merged

feat: add unmanaged service test call ff#3603
dagrest merged 1 commit into
masterfrom
feat/add-unmanaged-service-test-call-ff

Conversation

@dagrest

@dagrest dagrest commented Aug 18, 2022

Copy link
Copy Markdown

What does this PR do?

  • Implements Feature Flag to switch to a new polling function that uses a new Unmanaged Service APIs
  • Implements a new polling function that uses a new Unmanaged Service APIs

Where should the reviewer start?

Implementation begins in the following function: resolveAndTestFacts

How should this be manually tested?

Use the following options: test --unmanaged, do not forget to enable feature flag, current name is 'snykNewUnmanagedTest'

What are the relevant tickets?

Comment thread src/lib/ecosystems/resolve-test-facts.ts Outdated
Comment thread src/lib/ecosystems/resolve-test-facts.ts Outdated
Comment thread src/lib/ecosystems/resolve-test-facts.ts Outdated
Comment thread src/lib/ecosystems/resolve-test-facts.ts Outdated
Comment thread src/lib/ecosystems/types.ts Outdated
Comment thread test/jest/unit/lib/ecosystems/fixtures/create-dep-graph-response.ts Outdated
Comment thread test/jest/unit/lib/ecosystems/fixtures/create-dep-graph-response.ts
Comment thread test/jest/unit/lib/ecosystems/fixtures/get-dep-graph-response.ts Outdated
Comment thread src/lib/ecosystems/resolve-test-facts.ts Outdated
Comment thread src/lib/ecosystems/resolve-test-facts.ts Outdated
@danielroymoore
danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 695a7f7 to 87b7ab3 Compare September 13, 2022 15:05
Comment thread test/jest/unit/lib/ecosystems/fixtures/issues-response.ts Outdated
Comment thread src/lib/ecosystems/resolve-test-facts.ts Outdated
Comment thread src/lib/ecosystems/unmanaged/types.ts Outdated
Comment thread src/lib/polling/polling-test.ts Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we move this return into the try, and reduce number or variables, alternative use a const in the try-block.

Comment thread src/lib/polling/polling-test.ts Outdated
Comment thread src/lib/polling/polling-test.ts Outdated
Comment thread src/lib/polling/polling-test.ts Outdated
@danielroymoore
danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 87b7ab3 to d065704 Compare September 16, 2022 13:25
@danielroymoore
danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from d065704 to 1201f7c Compare September 16, 2022 14:46
@danielroymoore
danielroymoore force-pushed the feat/add-unmanaged-service-test-call-ff branch from 1201f7c to 55b6fbb Compare September 16, 2022 14:51
@dagrest
dagrest merged commit a3f87ba into master Sep 20, 2022
@dagrest
dagrest deleted the feat/add-unmanaged-service-test-call-ff branch September 20, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants