feat: add unmanaged service test call ff - #3603
Merged
Merged
Conversation
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
dekelund
reviewed
Aug 18, 2022
danielroymoore
force-pushed
the
feat/add-unmanaged-service-test-call-ff
branch
from
September 13, 2022 15:05
695a7f7 to
87b7ab3
Compare
dekelund
reviewed
Sep 14, 2022
dekelund
reviewed
Sep 14, 2022
dekelund
reviewed
Sep 14, 2022
dekelund
reviewed
Sep 14, 2022
There was a problem hiding this comment.
can't we move this return into the try, and reduce number or variables, alternative use a const in the try-block.
dekelund
reviewed
Sep 14, 2022
dekelund
reviewed
Sep 14, 2022
dekelund
reviewed
Sep 14, 2022
danielroymoore
force-pushed
the
feat/add-unmanaged-service-test-call-ff
branch
from
September 16, 2022 13:25
87b7ab3 to
d065704
Compare
dekelund
approved these changes
Sep 16, 2022
danielroymoore
force-pushed
the
feat/add-unmanaged-service-test-call-ff
branch
from
September 16, 2022 14:46
d065704 to
1201f7c
Compare
danielroymoore
force-pushed
the
feat/add-unmanaged-service-test-call-ff
branch
from
September 16, 2022 14:51
1201f7c to
55b6fbb
Compare
Avishagp
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
Implementation begins in the following function: resolveAndTestFacts
How should this be manually tested?
Use the following options: test --unmanaged, do not forget to enable feature flag, current name is 'snykNewUnmanagedTest'
What are the relevant tickets?