Skip to content

[PLEX - 2742] - local cre + simple latest block e2e test#23015

Open
ilija42 wants to merge 24 commits into
developfrom
PLEX-2742-local-cre-stellar
Open

[PLEX - 2742] - local cre + simple latest block e2e test#23015
ilija42 wants to merge 24 commits into
developfrom
PLEX-2742-local-cre-stellar

Conversation

@ilija42

@ilija42 ilija42 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Requires

Supports

@ilija42 ilija42 force-pushed the PLEX-2742-local-cre-stellar branch from d300103 to 6450f8a Compare July 3, 2026 11:21
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

CORA - Pending Reviewers

Codeowners Entry Overall Num Files Owners
* 💬 35 @smartcontractkit/foundations, @smartcontractkit/core
/core/capabilities/ 💬 2 @smartcontractkit/keystone, @smartcontractkit/capabilities-team
/core/services/workflows/ 14 @smartcontractkit/keystone
/deployment/ 💬 1 @smartcontractkit/ccip-tooling, @smartcontractkit/ccip-offchain, @smartcontractkit/keystone, @smartcontractkit/operations-platform, @smartcontractkit/core
/deployment/cre/ 3 @smartcontractkit/keystone, @smartcontractkit/operations-platform
/.github/** 💬 6 @smartcontractkit/devex-cicd, @smartcontractkit/devex-tooling, @smartcontractkit/core
/.github/workflows/devenv* 💬 1 @smartcontractkit/devex-tooling, @smartcontractkit/devex-cicd, @smartcontractkit/core
go.md 💬 1 @smartcontractkit/core, @smartcontractkit/foundations
go.mod 💬 7 @smartcontractkit/core, @smartcontractkit/foundations
go.sum 💬 7 @smartcontractkit/core, @smartcontractkit/foundations
integration-tests/go.mod 💬 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations
integration-tests/go.sum 💬 1 @smartcontractkit/core, @smartcontractkit/devex-tooling, @smartcontractkit/foundations

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@trunk-io

trunk-io Bot commented Jul 3, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CCIP_RegulatedTokenTransfer_Aptos2EVM The test failed because the Aptos node API could not be accessed on port 8080, likely indicating the API service was not available or not listening... Logs ↗︎
Test_CCIP_AptosMessageHasher_FuzzGeneratedCases Logs ↗︎
Test_CCIP_Messaging_EVM2Aptos Logs ↗︎
Test_CCIP_TokenTransfer_LnR_without_TransferRef_EVM2Aptos Logs ↗︎

... and 16 more

View Full Report ↗︎Docs

@ilija42 ilija42 marked this pull request as ready for review July 3, 2026 12:21
@ilija42 ilija42 requested review from a team as code owners July 3, 2026 12:21
// path (config.go requires a valid C-address). Reads (GetLatestLedger /
// ReadContract) never call the forwarder. Milestone B replaces this with the
// address of the deployed CRE forwarder.
placeholderForwarder = "CDLZFC3SYJYDZT7K67VZ75HPJVIEUVNIXF47ZG2FB2RMQQVU2HHGCYSC"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these three: requestTimeout, deltaStage and placeholderForwarder defaults? should it be possible to overwrite them via TOML and capability config? or not currently?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requestTimeout is part of the onchain capability config and is usually configured by writing the config to the contract, the other two are part of the capability config job spec


// registerStellarCapability registers the Stellar chain capability with its read
// methods. WriteReport / LogTrigger are Milestone B.
func registerStellarCapability(selector uint64) []keystone_changeset.DONCapabilityWithConfig {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this doesn't register anything, it just creates an object representing the configuration, why not inline it at the callsite?

}

func Test_CRE_V2_Stellar_Suite(t *testing.T) {
t.Parallel()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we only have 1 test for stellar environment, why is this needed? in the future if we have more will that also work? or will we need to do, what we do for tests that share the environment and need to use different private keys?

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0989a12bce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread core/scripts/cre/environment/configs/setup.toml
@ilija42 ilija42 force-pushed the PLEX-2742-local-cre-stellar branch from 0989a12 to 05390f0 Compare July 6, 2026 17:42
@cl-sonarqube-production

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants