This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Update URI - #11
Merged
Merged
Conversation
garyb
approved these changes
Mar 1, 2018
garyb
left a comment
garyb
left a comment
Member
There was a problem hiding this comment.
I was going to suggest we just pass options with the URI to tileLayer / setURI, but I see that's perhaps a bit more of a problem for ConvertDict.
cryogenian
reviewed
Mar 1, 2018
| InteractiveLayerConf | ||
| ( iconUrl ∷ URIRef | ||
| , iconRetinaUrl ∷ URIRef | ||
| ( iconUrl ∷ LeafURIRef |
Member
There was a problem hiding this comment.
iconUrl, iconRetinaUrl, shadowUrl and shadowRetinaUrl are common uris btw, they don't have any special meanings for {{x|y|z}}
Contributor
Author
There was a problem hiding this comment.
I don't understand what you mean, can you explain ?
Member
There was a problem hiding this comment.
setURI function sets special uri that could have { and } inside. iconUrl and friends couldn't they are just old plain URI w/o any fancy template strings inside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.