Skip to content

fix(web): send structured values to "assistant.threads.setStatus" method using json content type #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 3 commits into from
Sep 30, 2025
Merged

fix(web): send structured values to "assistant.threads.setStatus" method using json content type #1754

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2390de8
fix: send structured values using json content type
zimeg Sep 30, 2025
39facd9
docs(chore): generate reference
zimeg Sep 30, 2025
922d730
Merge branch 'ai-apps' into zimeg-fix-web-json-loading-states
mwbrooks Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion slack_sdk/web/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2084,7 +2084,8 @@ async def assistant_threads_setStatus(
kwargs.update(
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
)
return await self.api_call("assistant.threads.setStatus", params=kwargs)
kwargs = _remove_none_values(kwargs)
return await self.api_call("assistant.threads.setStatus", json=kwargs)

async def assistant_threads_setTitle(
self,
Expand Down
3 changes: 2 additions & 1 deletion slack_sdk/web/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2074,7 +2074,8 @@ def assistant_threads_setStatus(
kwargs.update(
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
)
return self.api_call("assistant.threads.setStatus", params=kwargs)
kwargs = _remove_none_values(kwargs)
return self.api_call("assistant.threads.setStatus", json=kwargs)

def assistant_threads_setTitle(
self,
Expand Down
3 changes: 2 additions & 1 deletion slack_sdk/web/legacy_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2086,7 +2086,8 @@ def assistant_threads_setStatus(
kwargs.update(
{"channel_id": channel_id, "thread_ts": thread_ts, "status": status, "loading_messages": loading_messages}
)
return self.api_call("assistant.threads.setStatus", params=kwargs)
kwargs = _remove_none_values(kwargs)
return self.api_call("assistant.threads.setStatus", json=kwargs)

def assistant_threads_setTitle(
self,
Expand Down
12 changes: 12 additions & 0 deletions tests/slack_sdk_async/web/test_web_client_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,19 @@ async def run_method(self, method_name, method, async_method):
self.api_methods_to_call.remove(
method(channel_id="D111", thread_ts="111.222", status="is typing...")["method"]
)
method(
channel_id="D111",
thread_ts="111.222",
status="is typing...",
loading_states=["Thinking...", "Writing..."],
)
await async_method(channel_id="D111", thread_ts="111.222", status="is typing...")
await async_method(
channel_id="D111",
thread_ts="111.222",
status="is typing...",
loading_states=["Thinking...", "Writing..."],
)
elif method_name == "assistant_threads_setTitle":
self.api_methods_to_call.remove(method(channel_id="D111", thread_ts="111.222", title="New chat")["method"])
await async_method(channel_id="D111", thread_ts="111.222", title="New chat")
Expand Down