fix(mcp): reject unknown pre-positional flags in add - #3048
Closed
afjcjsbx wants to merge 2 commits into
Closed
Conversation
This was referenced Jun 12, 2026
|
This PR has had no activity for 7 days and has been marked as stale. If you are still working on it, please push an update or leave a comment; otherwise it will be closed automatically in 7 days. |
This was referenced Jun 20, 2026
|
This PR has been closed after 14 days of inactivity. If you would like to continue, feel free to reopen it or submit a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixes
mcp addargument parsing when root-level persistent flags are passed before the subcommand, such as--no-color.mcp addusesDisableFlagParsing: true, so inherited root flags could leak into the custom parser and be misinterpreted as positional arguments. In practice this brokehttp/sseserver registration and could also silently save incorrect stdio server names.This PR:
mcp addparses its own arguments--prefixed arguments seen before the required positional arguments🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
Fixes #3041
📚 Technical Context (Skip for Docs)
mcp addmis-parses global flags into positionals (DisableFlagParsing), breaking http/sse adds and silently mis-naming stdio servers #3041mcp adddisables Cobra flag parsing and parses raw args manually. When a root persistent flag like--no-colorappears beforemcp add, it can arrive unconsumed inparseAddArgsand be incorrectly treated as the server name. This change filters inherited flags before custom parsing and rejects unknown pre-positional flags instead of silently demoting them to positionals.🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
GOCACHE=/tmp/picoclaw-gocache go test ./cmd/picoclaw/internal/mcp -count=1 ok github.com/sipeed/picoclaw/cmd/picoclaw/internal/mcp 1.162sRegression coverage added for:
mcp addpositionals (--no-color)☑️ Checklist