Fix pMapIterable when accepting async values in an iterator - #69
Merged
Conversation
Owner
|
// @Richienb |
Contributor
|
Seems fine but would appreciate some type tests for all four (?) types of |
Contributor
Author
|
Sure I'll add it now |
Contributor
Author
|
@Richienb please take another look 🙏🏻 |
Richienb
approved these changes
Dec 26, 2023
This was referenced Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Changed the shared input to include a promise as this is the sample in the basic usage.
I also fixed
pMapIterableto await on values as it's type allowsIterator<Element | Promise<Element>>.The tests cover this fix.
Related to https://github.com/sindresorhus/p-filter/pull/8
Thanks!