Skip to content

improvement(sidebar): overlay lock indicator on leading icon #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 5 commits into from
May 3, 2026
Merged

improvement(sidebar): overlay lock indicator on leading icon #4412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d17b22c
improvement(sidebar): overlay lock indicator on leading icon
waleedlatif1 May 3, 2026
ef08edc
fix(sidebar): correct lock indicator HTML nesting and a11y
waleedlatif1 May 3, 2026
802d013
improvement(sidebar): swap lock indicator with more button on hover
waleedlatif1 May 3, 2026
9892089
fix(sidebar): gate pointer-events on lock and more button visibility
waleedlatif1 May 3, 2026
90abdb4
fix(sidebar): add role=img so lock indicator is announced by AT
waleedlatif1 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 25 additions & 16 deletions ...eId]/w/components/sidebar/components/workflow-list/components/folder-item/folder-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,26 +552,35 @@ export function FolderItem({
>
{folder.name}
</span>
</div>
<div className='relative h-[18px] w-[18px] flex-shrink-0'>
{folder.locked && (
<Lock
className='pointer-events-none h-[12px] w-[12px] flex-shrink-0 text-[var(--text-icon)]'
<span
role='img'
aria-label='Folder is locked'
/>
className={clsx(
'pointer-events-none absolute inset-0 flex items-center justify-center transition-opacity',
!isAnyDragActive && 'group-hover:opacity-0',
isContextMenuOpen && 'opacity-0'
)}
>
<Lock className='h-[14px] w-[14px] text-[var(--text-icon)]' aria-hidden='true' />
</span>
Comment thread
waleedlatif1 marked this conversation as resolved.
)}
<button
type='button'
aria-label='Folder options'
onPointerDown={handleMorePointerDown}
onClick={handleMoreClick}
className={clsx(
'pointer-events-none absolute inset-0 flex items-center justify-center rounded-sm opacity-0 transition-opacity',
!isAnyDragActive && 'group-hover:pointer-events-auto group-hover:opacity-100',
isContextMenuOpen && 'pointer-events-auto opacity-100'
)}
>
<MoreHorizontal className='h-[16px] w-[16px] text-[var(--text-icon)]' />
</button>
</div>
<button
type='button'
aria-label='Folder options'
onPointerDown={handleMorePointerDown}
onClick={handleMoreClick}
className={clsx(
'flex h-[18px] w-[18px] flex-shrink-0 items-center justify-center rounded-sm opacity-0 transition-opacity',
!isAnyDragActive && 'group-hover:opacity-100',
isContextMenuOpen && 'opacity-100'
)}
>
<MoreHorizontal className='h-[16px] w-[16px] text-[var(--text-icon)]' />
</button>
</div>
)}
</div>
Expand Down
29 changes: 18 additions & 11 deletions .../w/components/sidebar/components/workflow-list/components/workflow-item/workflow-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,31 +468,38 @@ export function WorkflowItem({
{workflow.name}
</div>
)}
{!isEditing && workflow.locked && (
<Lock
className='pointer-events-none h-[12px] w-[12px] flex-shrink-0 text-[var(--text-icon)]'
aria-label='Workflow is locked'
/>
)}
{!isEditing && <Avatars workflowId={workflow.id} />}
</div>
</div>
{!isEditing && (
<>
<div className='relative h-[18px] w-[18px] flex-shrink-0'>
{workflow.locked && (
<span
role='img'
aria-label='Workflow is locked'
className={clsx(
'pointer-events-none absolute inset-0 flex items-center justify-center transition-opacity',
!isAnyDragActive && 'group-hover:opacity-0',
isContextMenuOpen && 'opacity-0'
)}
>
<Lock className='h-[14px] w-[14px] text-[var(--text-icon)]' aria-hidden='true' />
</span>
)}
<button
type='button'
aria-label='Workflow options'
onPointerDown={handleMorePointerDown}
onClick={handleMoreClick}
className={clsx(
'flex h-[18px] w-[18px] flex-shrink-0 items-center justify-center rounded-sm opacity-0 transition-opacity',
!isAnyDragActive && 'group-hover:opacity-100',
isContextMenuOpen && 'opacity-100'
'pointer-events-none absolute inset-0 flex items-center justify-center rounded-sm opacity-0 transition-opacity',
!isAnyDragActive && 'group-hover:pointer-events-auto group-hover:opacity-100',
isContextMenuOpen && 'pointer-events-auto opacity-100'
)}
>
<MoreHorizontal className='h-[16px] w-[16px] text-[var(--text-icon)]' />
</button>
</>
</div>
)}
</Link>

Expand Down
Loading