-
-
Notifications
You must be signed in to change notification settings - Fork 108
[codex] Add Shakapacker brand assets #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
b8e6e3d
7290273
b9fb4cc
f75b075
f93f7a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,15 @@ | ||||||||||||||||||||||||||||
| # Shakapacker (v10) | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| <p align="center"> | ||||||||||||||||||||||||||||
| <a href="https://shakapacker.com"> | ||||||||||||||||||||||||||||
| <picture> | ||||||||||||||||||||||||||||
| <source media="(prefers-color-scheme: dark)" srcset="./assets/brand/lockup-dark.svg"> | ||||||||||||||||||||||||||||
| <source media="(prefers-color-scheme: light)" srcset="./assets/brand/lockup-light.svg"> | ||||||||||||||||||||||||||||
| <img src="./assets/brand/lockup-light.svg" alt="Shakapacker: Rails asset bundling with modern build systems" width="760"> | ||||||||||||||||||||||||||||
| </picture> | ||||||||||||||||||||||||||||
| </a> | ||||||||||||||||||||||||||||
| </p> | ||||||||||||||||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hero omits dark lockup variantLow Severity The README hero is a single light lockup PNG, while this change adds Reviewed by Cursor Bugbot for commit f93f7a5. Configure here.
Comment on lines
+1
to
+5
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| _🚀 Shakapacker 10 supports [Rspack](https://rspack.rs/) — up to 17x faster than webpack per [upstream benchmarks](./docs/transpiler-performance.md#published-benchmarks)!_ | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # Shakapacker Brand Assets | ||
|
|
||
| This directory contains the canonical Shakapacker folded-S icon and lockup assets. | ||
|
|
||
| The root `apple-touch-icon.png`, `favicon.png`, and `favicon.svg` files are copies of these assets for repository tools, including Conductor's repo icon discovery. `assets/icon.png` is a generic high-resolution fallback for tools that look in `assets/`. |


Uh oh!
There was an error while loading. Please reload this page.